Skip to content

use proper error mode in items::parse() #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Conversation

yuankunzhang
Copy link
Contributor

No description provided.

@yuankunzhang yuankunzhang marked this pull request as draft May 19, 2025 14:13
@yuankunzhang yuankunzhang force-pushed the main branch 3 times, most recently from 25749f1 to 4615d76 Compare May 19, 2025 14:38
@yuankunzhang yuankunzhang marked this pull request as ready for review May 19, 2025 14:38
@yuankunzhang
Copy link
Contributor Author

The fuzzing error stems from this line: when the offset is +24 hours, the call to FixedOffset::east_opt overflows.

I will look for a solution later.

@sylvestre
Copy link
Contributor

this is why i love fuzzers :)

@yuankunzhang
Copy link
Contributor Author

This issue is resolved in #145.

@sylvestre
Copy link
Contributor

seems that the fuzzer died with e774e26sec+\011

@yuankunzhang
Copy link
Contributor Author

seems that the fuzzer died with e774e26sec+\011

Addressed in #148.

@sylvestre sylvestre merged commit 1a6a6f6 into uutils:main Jun 4, 2025
17 checks passed
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1552608) to head (294bd5e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #143   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants